Skip to content

build: wasip1 is broken on wasmedge runtime  #60097

Open
Open
build: wasip1 is broken on wasmedge runtime #60097
Labels
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.arch-wasmWebAssembly issues
Milestone
Backlog

Description

@johanbrandhorst
johanbrandhorst
opened on May 10, 2023

This is a tracking issue for issues surrounding the use of the new wasip1 GOOS target on the wasmedge Wasm runtime. We currently do not have a wasmedge runner.

This issue should not be considered done until we have a working wasmedge runner and all tests are either passing or we have documented the failures which we cannot reasonably fix.

Currently known failing tests:

Package Test name Error Test log Fixed
archive/zip TestOpenReaderInsecurePath Unable to write out the bugos zip entry Full log ✔️
all N/A Test timeout Full log

Activity

  1. johanbrandhorst
    added
    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
    arch-wasmWebAssembly issues
    on May 10, 2023
  2. johanbrandhorst
    added this to the Backlog milestone on May 10, 2023

  3. gopherbot commented on May 10, 2023

    @gopherbot
    gopherbot
    on May 10, 2023
    Contributor

    Change https://go.dev/cl/493696 mentions this issue: all: add wasmedge wasip1 runner

  4. gopherbot commented on May 10, 2023

    @gopherbot
    gopherbot
    on May 10, 2023
    Contributor

    Change https://go.dev/cl/494120 mentions this issue: misc/wasm: add wasmedge to wasip1 script

  5. gopherbot
    added 2 commits that reference this issue on May 10, 2023

    all: add wasmedge wasip1 runner

    fc985e8

    misc/wasm: add wasmedge to wasip1 script

    dc076ea

  6. johanbrandhorst commented on May 11, 2023

    @johanbrandhorst
    johanbrandhorst
    on May 11, 2023
    MemberAuthor

    The runner has been created and once the builders have been redeployed I will run it to see where it fails.

  7. gopherbot commented on May 16, 2023

    @gopherbot
    gopherbot
    on May 16, 2023
    Contributor

    Change https://go.dev/cl/495078 mentions this issue: misc/wasm: test commit

  8. gopherbot commented on May 18, 2023

    @gopherbot
    gopherbot
    on May 18, 2023
    Contributor

    Change https://go.dev/cl/496076 mentions this issue: env: add runtime library to wasmedge runner

  9. gopherbot
    added a commit that references this issue on May 18, 2023

    env: add runtime library to wasmedge runner

    97f144a

  10. johanbrandhorst commented on May 19, 2023

    @johanbrandhorst
    johanbrandhorst
    on May 19, 2023
    MemberAuthor

    OK after some fixes I managed to run the test suite against wasmedge and the first failure we're seeing is:

    --- FAIL: TestOpenReaderInsecurePath (0.01s)
    reader_test.go:1386: Unable to write out the bugos zip entry
FAIL
FAIL	archive/zip	8.807s

    I've updated the table at the top. This is a new type of error so more investigation will be necessary.

  11. gopherbot commented on May 26, 2023

    @gopherbot
    gopherbot
    on May 26, 2023
    Contributor

    Change https://go.dev/cl/498616 mentions this issue: misc/wasm: set PATH variable in exec

  12. gopherbot
    added a commit that references this issue on May 26, 2023

    misc/wasm: set PATH variable in exec

    188066c

  13. johanbrandhorst commented on Jun 2, 2023

    @johanbrandhorst
    johanbrandhorst
    on Jun 2, 2023
    MemberAuthor

    Seems this test failure fixed itself, but now we have a new failure:

    ##### Testing packages.
*** Test killed with quit: ran too long (4m0s).
signal: quit (core dumped)
FAIL	archive/tar	240.085s
*** Test killed with quit: ran too long (4m0s).
signal: quit (core dumped)
FAIL	archive/zip	240.090s
*** Test killed with quit: ran too long (4m0s).
signal: quit (core dumped)
FAIL	bufio	240.058s
FAIL
go tool dist: Failed: exit status 1

    Looks like execution is a bit too slow at this time. I will experiment with increasing the timeout to see if run into any other errors.

  14. johanbrandhorst commented on Jun 3, 2023

    @johanbrandhorst
    johanbrandhorst
    on Jun 3, 2023
    MemberAuthor

    Even with a bumped timeout we see the same error: https://storage.googleapis.com/go-build-log/767af70d/wasip1-wasm-wasmedge_4134807c.log. We have an outstanding issue on the WasmEdge project that may need to be resolved before we can move forward with this: WasmEdge/WasmEdge#2445.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.arch-wasmWebAssembly issues

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions