build: remove -Werror from cmd/dist build for Go 1.4 release branch #12345

Activity

1. minux commented on Aug 26, 2015

   

   minux

   on Aug 26, 2015 via email

   Member

   More actions

   This brought up the issue of whether we should continue maintaining Go 1.4 given that it's the last version without circular dependency on another Go compiler. Normally, once a new stable release is released, we will stop maintaining the older ones, but I can see why this might not be desirable for 1.4.
2. bradfitz commented on Aug 26, 2015

   

   bradfitz

   on Aug 26, 2015

   Contributor

   More actions

   FreeBSD should feel free to silence any clang undefined behavior warnings from versions of clang that are newer than we ever built Go 1.4 with.

   Because Go 1.5 is now out, and because Go 1.5 no longer contains any C code, we probably won't be making such changes upstream, nor in the Go 1.4 release branch (which we only use for critical problems).

   If you'd like us to review any patches, please email golang-dev@ or ping this bug and somebody can take a look.

   /cc @ianlancetaylor for the linker parts.
3. bradfitz

   added this to the Unplanned milestone on Aug 26, 2015
4. bradfitz

   added

   OS-FreeBSD

   on Aug 26, 2015
5. bradfitz

   changed the title [-]Go 1.4 fails to compile with clang 3.7[/-] [+]build: Go 1.4 fails to compile with clang 3.7[/+] on Aug 26, 2015
6. bradfitz commented on Aug 26, 2015

   

   bradfitz

   on Aug 26, 2015

   Contributor

   More actions

   @minux, that is a fair point.
7. jlaffaye commented on Aug 26, 2015

   

   jlaffaye

   on Aug 26, 2015

   Author

   More actions

   I could apply patches to Go source files in the FreeBSD port, but having fixes in upstream would avoid every package maintainer to maintain their own set of patches.
8. minux commented on Aug 26, 2015

   

   minux

   on Aug 26, 2015 via email

   Member

   More actions

   I think we can slightly soften the rules regarding 1.4 point releases. We can definitely import the 2nd patch (uvlong) as it's obviously safe and fix a compilation problem. (On the other hand, disable the warning is also a valid workaround, but it's slightly harder as the code is being compiled by cmd/dist.) The 1st problem is slightly different. I think a valid workaround is to disable cgo when building Go 1.4 (export CGO_ENABLED=0 before running make.bash), because bootstrapping Go 1.5 doesn't require cgo.
9. minux commented on Aug 26, 2015

   

   minux

   on Aug 26, 2015 via email

   Member

   More actions

   My proposal is we continue to maintain Go 1.4 for already supported platform for the sole purpose of bootstrapping Go 1.5+ for as long as it's reasonable, but we don't issue new point releases. Interested parties can always get from git. For example, future OS releases might complete break Go 1.4's net package, but as it's not required for bootstrapping Go 1.5+, we won't fix those problems. The exception is that if the required change is too big, we can stop supporting that platform in Go 1.4, but I think it's a fairly unlikely event, at least for the near future.
10. ianlancetaylor commented on Aug 26, 2015

    

    ianlancetaylor

    on Aug 26, 2015

    Contributor

    More actions

    In general I agree with minux that we need to ensure that Go 1.4 builds at least well enough to build Go 1.5. I actually think that we might need to make new point release in some cases.

    In this case, I think we should consider a patch for 1.4 that drops -Werror from the list of command line options. And I think that the FreeBSD build process should set CGO_ENABLED=0 when building Go 1.4. I think those two steps should fix the FreeBSD build.
11. ianlancetaylor

    modified the milestones: Go1.4.3, Unplanned on Aug 26, 2015
12. minux commented on Aug 26, 2015

    

    minux

    on Aug 26, 2015 via email

    Member

    More actions

    Yeah, dropping -Werror is much better and more future-proof. My reason for not making new point releases is because I think making the binary distributions is too time consuming. For those build issues, we just need to do a new source code release.
13. rsc commented on Aug 26, 2015

    

    rsc

    on Aug 26, 2015

    Contributor

    More actions

    I don't believe that Go 1.4 needs to build anywhere except linux/amd64 and darwin/amd64 (just to take an extreme position). We did not backport linux/ppc64 to Go 1.4 just to make Go 1.5 build there. The requirement is "Go 1.4 or later". The or later is implemented nearly trivially by bootstrap.bash.
14. ianlancetaylor commented on Aug 26, 2015

    

    ianlancetaylor

    on Aug 26, 2015

    Contributor

    More actions

    Building only on GNU/Linux and Darwin works for us but seems a little unfair to FreeBSD. In any case these particular issues are presumably going to arise on other platforms too as they move to newer versions of clang.

    I'm only proposing one patch to 1.4 at this time: drop -Werror from cmd/dist/build.c.

    @minux I agree that only a new source release is needed, if anything is needed.
15. 5 remaining items

    Load more

16. andrewchambers commented on Aug 27, 2015

    

    andrewchambers

    on Aug 27, 2015

    More actions

    -Werror is great for programmers, but horrible for distributors/end users. The number of compiler diagnostics will only increase as the years pass. This highlights why go vet is a better design than compiler warnings.
17. minux

    added a commit that references this issue on Sep 3, 2015

    cmd/dist: remove -Werror from CFLAGS

    ...

    This issue will close once commit a527bdb is merged into the 'master' branch.

    a527bdb
18. minux

    closed this as completedon Sep 12, 2015
19. vanadium-bot

    added a commit that references this issue on Mar 23, 2016

    jiri-profile-v23: Use Go 1.4.3 and not 1.4.2 for bootstrapping.

    ...

    1ec703a
20. madisongh

    added 3 commits that reference this issue on Sep 8, 2016

    Bump bootstrap to 1.4.3 to fix compiler error (#4)

    ...

    840c695

    Bump bootstrap to 1.4.3 to fix compiler error (#4)

    ...

    6abcb79

    Bump bootstrap to 1.4.3 to fix compiler error (#4)

    ...

    a5adbe4
21. golang

    locked and limited conversation to collaborators on Sep 22, 2016
22. gopherbot

    added

    FrozenDueToAge

    on Sep 22, 2016
23. wheatman

    added 2 commits that reference this issue on Jun 25, 2018

    cmd/dist: remove -Werror from CFLAGS

    ...

    This issue will close once commit 39f11e1 is merged into the 'akaros' branch.

    39f11e1

    cmd/dist: remove -Werror from CFLAGS

    ...

    This issue will close once commit 1c79389 is merged into the 'akaros' branch.

    1c79389
24. wheatman

    added a commit that references this issue on Jul 9, 2018

    cmd/dist: remove -Werror from CFLAGS

    ...

    This issue will close once commit 4c8a683 is merged into the 'akaros' branch.

    4c8a683
25. wheatman

    added a commit that references this issue on Jul 20, 2018

    cmd/dist: remove -Werror from CFLAGS

    ...

    This issue will close once commit a36be74 is merged into the 'akaros' branch.

    a36be74
26. wheatman

    added a commit that references this issue on Jul 30, 2018

    cmd/dist: remove -Werror from CFLAGS

    ...

    This issue will close once commit b23b3ea is merged into the 'akaros' branch.

    b23b3ea
27. arran4

    added a commit that references this issue on Feb 24, 2026

    path/filepath: add SplitListSeq and SplitNames

    ...

    This issue will close once commit 0dd20a2 is merged into the 'master' branch.

    0dd20a2